]> dgit.raspbian.org Git - gnome-shell.git/commit
misc/objectManager: Fix emission of object-removed signal
authorJonas Dreßler <verdre@v0yd.nl>
Mon, 3 Apr 2023 14:12:59 +0000 (16:12 +0200)
committerMarge Bot <marge-bot@gnome.org>
Wed, 5 Apr 2023 18:43:51 +0000 (18:43 +0000)
commit8431e7ae51fb9007a815f8e72592df529ce44ba3
tree07922fcaf607e17b637ef116fb189cfa6cbe4a87
parent3f956fbdb60df012dbee63626d7d11ccfe11d0db
misc/objectManager: Fix emission of object-removed signal

Emitting this signal is broken right now: We check for a length of 0 on
this._objects[objectPath], but the
`this._objects[objectPath][interfaceName] = null` we do before the
check doesn't actually remove the key, it only sets the value to null,
leaving the key around and thus the amount of entries in the object doesn't
change.

Fix that by using the delete statement instead, "delete" properly removes
the key and thus affects the amount of entries in the object, making our
length === 0 check effective.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2730>
js/misc/objectManager.js